On Fri, Jan 16, 2015 at 11:49 AM, Nathan Sidwell <[email protected]> wrote:
> On 01/14/15 23:11, Richard Smith wrote:
>>
>> +typedef std::set<QualType, QualTypeOrdering> IndirectBaseSet;
>>
>> Use llvm::SmallPtrSet rather than std::set here. Other than that, just
>> some typographical comments:
>
>
> Thanks for review. This version moves to a SmallPtrSet and addresses your
> other comments. I hope.
>
> ok?
LGTM. Please convert tabs to spaces prior to commit (there are about
half a dozen lines with hard tabs in this patch), and put this { on
the previous line:
+NoteIndirectBases(ASTContext &Context, IndirectBaseSet &Set,
+ const QualType &Type)
+{
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
