On 1/16/2015 8:33 PM, Pekka Jääskeläinen wrote:
On 01/15/2015 05:28 AM, Sameer Sahasrabuddhe wrote:
This implements Section 3.7 from the SPIR 1.2 spec:
SPIR kernels should use "spir_kernel" calling convention.
Non-kernel functions use "spir_func" calling convention. All
other calling conventions are disallowed.
The patch works only for OpenCL source. Any other uses will need to
ensure
that kernels are assigned the spir_kernel calling convention correctly.
Note that the patch modifies how ASTContext determines the default
calling
convention. This *may* need a closer look, but it does pass lit tests
on all
targets.
It looks fine to me.
Is that an LGTM?
Sameer.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
