Address @jroelofs comments.
================ Comment at: CMakeLists.txt:149 @@ +148,3 @@ +if (LIBCXXABI_LIBCXX_PATH STREQUAL "LIBCXXABI_LIBCXX_PATH-NOTFOUND") + message(WARNING "LIBCXXABI_LIBCXX_PATH was not specified and couldn't be infered.") + set(LIBCXXABI_LIBCXX_PATH "") ---------------- jroelofs wrote: > shouldn't this be an error? Probably not. Currently we only need the libc++ source directory if we run the tests. Otherwise finding the headers is enough to just build it. If we make this an error we lose the ability to build libc++abi without the libc++ sources. http://reviews.llvm.org/D7130 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
