Generally makes sense to me - how does the experience change in the actual code completion of overloads in an editor using this?
================ Comment at: lib/Sema/SemaCodeComplete.cpp:2840-2841 @@ +2839,4 @@ + Opt.AddChunk(CodeCompletionString::CK_Comma); + AddOverloadParameterChunks(Context, Policy, Function, Prototype, Opt, + CurrentArg, P, /*InOptional=*/true); + Result.AddOptionalChunk(Opt.TakeString()); ---------------- So we're both recursing and looping? This seems like a strange pattern to me, that at least needs a comment. http://reviews.llvm.org/D7152 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
