Hi Sameer, Couple of quick ones:
- to me it's unintuitive that the check functions return 'false' if the checked thing is _valid_, but if this is common elsewhere in Clang (as it seems), fine - OpenCLCheckVectorConditional needs a comment of its return value and in the function name seems unintuitive as it's doing more than checking, again, if this is a Clang convention, fine - some of the diagnostics error message vector types have pretty printed OpenCL C vector datatypes (typedef'd names), some refer to the underlying __attribute__'d type (when complaining about func return values?) -- is there something that can be done to make them all print the OpenCL C specs datatype name? Otherwise LGTM. On 01/23/2015 05:26 AM, Sameer Sahasrabuddhe wrote:
When the condition is a vector, OpenCL specifies additional requirements on the operand types, and also the operations required to determine the result type of the operator. This is a combination of OpenCL v1.1 s6.3.i and s6.11.6, and the semantics remain unchanged in later versions of OpenCL. The attached patch implements these requirements. Sameer. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-- Pekka _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
