On Wed, Feb 4, 2015 at 11:52 AM, Justin Holewinski <[email protected]> wrote: > On Wed, 2015-02-04 at 11:42 -0800, Hans Wennborg wrote: >> On Mon, Feb 2, 2015 at 1:05 PM, Justin Holewinski >> <[email protected]> wrote: >> > Author: jholewinski >> > Date: Mon Feb 2 15:05:49 2015 >> > New Revision: 227861 >> > >> > URL: http://llvm.org/viewvc/llvm-project?rev=227861&view=rev >> > Log: >> > When generating llvm.used, we may need an addrspacecast instead of a >> > bitcast. >> > >> > Summary: >> > This is especially important for targets that use multiple address spaces, >> > and commonly place global variables in address spaces other than zero. >> > >> > Fixes PR22383 >> > >> > Test Plan: New test case added: llvm-used.cu >> > >> > Reviewers: jingyue >> > >> > Subscribers: llvm-commits >> > >> > Differential Revision: http://reviews.llvm.org/D7345 >> >> Is this something we should merge to the 3.6 branch? > > Very likely, yes. Though it should only affect targets that make use of > non-zero address spaces, like NVPTX and R600.
I've merged it in r228185. Thanks, Hans _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
