Great. I am pretty sure none of the tests requires SDKROOT to pass. I will just remove the code that setup the environment and add it to blacklist.
> On Feb 4, 2015, at 3:54 PM, Daniel Dunbar <[email protected]> wrote: > > Nope... > > - Daniel > > On Wed, Feb 4, 2015 at 10:16 AM, Steven Wu <[email protected] > <mailto:[email protected]>> wrote: > cc Daniel. Do you remember the reason why you add SDKROOT to lit for clang? > > Steven > >> On Feb 3, 2015, at 2:10 PM, Steven Wu <[email protected] >> <mailto:[email protected]>> wrote: >> >> Hi Reid >> >> Thanks for the suggestion. I am aware of the setting in lit.cfg but I assume >> some of the environment variables I want to remove from the driver tests >> might be useful in some other cases. >> For example, SDKROOT is setup by lit.cfg. Although I am not aware of any >> clang tests will fail on mac os if this environment is not set (maybe >> compiler_rt really need it), setting that environment to the wrong path will >> definitely fail many driver tests. I am just being cautious by removing them >> only from driver tests, but I can try remove them from all clang tests and >> see what will happen. >> >> Steven >> >>> On Feb 3, 2015, at 1:55 PM, Reid Kleckner <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> We already have this mechanism in test/lit.cfg. Feel free to add some more >>> variables. >>> >>> On Tue, Feb 3, 2015 at 1:17 PM, Steven Wu <[email protected] >>> <mailto:[email protected]>> wrote: >>> Ping. This is intended to avoid driver tests gets broken by the unexpected >>> environment variable. They can be accidentally set by user or bots and >>> report false positive in driver tests. >>> >>> >>> http://reviews.llvm.org/D7135 <http://reviews.llvm.org/D7135> >>> >>> EMAIL PREFERENCES >>> http://reviews.llvm.org/settings/panel/emailpreferences/ >>> <http://reviews.llvm.org/settings/panel/emailpreferences/> >>> >>> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> [email protected] <mailto:[email protected]> >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>> <http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits> >>> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] <mailto:[email protected]> >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> <http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits> > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
