================
Comment at: lib/Sema/SemaDecl.cpp:132
@@ +131,3 @@
+namespace {
+enum BasesLookupResult { NotFound, FoundNotType, FoundType };
+} // namespace
----------------
ABataev wrote:
> rsmith wrote:
> > rnk wrote:
> > > "FoundNonType" would be closer to the standardese terminology of 
> > > "non-type template parameter"
> > This should either be an enum class or should use a prefix for its names; 
> > these identifiers seem too general to drop into global scope here.
> Turned enum into enum class and renamed FoundNotType to 
> FoundNonTypeTemplateParam
Well, we aren't searching for template parameters specifically, so I'd still 
prefer FoundNonType. :)

http://reviews.llvm.org/D7173

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to