================
Comment at: src/Unwind/EHHeaderParser.hpp:111
@@ +110,3 @@
+  size_t high = hdrInfo.fdeCount;
+  while (low < high) {
+    size_t mid = (low + high) / 2;
----------------
danalbert wrote:
> danalbert wrote:
> > jroelofs wrote:
> > > The EHABI unwinder uses some library function for doing its binary search 
> > > for the EHT entry. Maybe that can be re-used here too.
> > I'll look in to that.
> The case you were thinking of is 
> https://github.com/llvm-mirror/libcxxabi/blob/master/src/Unwind/UnwindCursor.hpp#L676
> 
> That's a dependency on libc++, and you've been trying to fix the layering 
> issues here. I don't think I'll add to them :)
yeah, that's it. I forgot it was using something from std::. Agreed, no need to 
add one more layering problem.

http://reviews.llvm.org/D6848

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to