A 4-line change in a sea of lines changed is impossible for a reviewer to see; please do it in a separate patch. Also, if this commit obsoletes the module-map-checker tool, please remove it in this same patch.
Also, teaching modularize to use a module map file as input to its (pre-module-map-checker-integration) duties is a logically separate change and should be done in a separate patch. It's difficult for somebody to sign off on this patch with three (or more?) logically separate changes in it (especially when one of them is a very large mechanical change). There might be smaller changes that will have to be done before and after the large mechanical change (to prepare for the large mechanical change (e.g. to make it possible to actually have the large mechanical change be a single clear commit) or to better integrate things/clean things up once the large mechanical change has taken place). http://reviews.llvm.org/D7475 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
