> On Feb 10, 2015, at 11:50 AM, Chandler Carruth <[email protected]> wrote:
> 
> This seems like a generally good thing to do if we're testing backtraces.
> 
> Do you want to merge the REQUIRES lines? I don't feel strongly either way.
Didn’t know we could.  Thats useful.  I merged them and retested that it still 
works.
> 
> Feel free to commit whenever.
Thanks.  Its r228735

Pete
> 
> On Tue, Feb 10, 2015 at 11:13 AM, Pete Cooper <[email protected] 
> <mailto:[email protected]>> wrote:
> Hi Chandler, Owen
> 
> In your patches to LLVM which changed ThreadLocal and PrettyStackTrace, we 
> ended up requiring ENABLE_BACKTRACES for PrettyStackTrace.
> 
> Trouble is, clang has 2 tests which check for the pretty stack trace on 
> crashes.  This patch teaches lit about the ENABLE_BACKTRACES option, and 
> updates those 2 tests to use that option.  Without this patch, clang fails to 
> pass llvm-lit without back traces.
> 
> Thanks,
> Pete
> 
> 

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to