LGTM
================
Comment at: libcxx/test/config.py:111
@@ +110,3 @@
+ def configure_target_info(self):
+ info_str = self.get_lit_conf('target_info', "None")
+ self.target_info = eval(info_str)
----------------
I'd prefer `importlib` + `getattr` instead of `eval`.
http://reviews.llvm.org/D7601
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
