Thanks, LGTM On Wed, Feb 18, 2015 at 9:33 AM, Nathan Sidwell <[email protected]> wrote:
> On 02/17/15 21:35, Richard Smith wrote: > >> Sorry for the delay. The patch looks good, other than some style issues: >> > > No spaces before (). >> > Damn, I checked so carefully ... > > Please add braces around this 'if', since its body contains many lines. >> > done > > test/CXX/dcl.decl/dcl.meaning/dcl.fct.default/p9.cpp >> >> I'm not really sure what part of p9 this is testing; it seems more to be >> a test >> of p4, where inheritance of default arguments is specified. >> > > Ah, I'd not understood the naming convention here. I've moved that code > into p4.cpp. > > > tested on x86_64-linux, ok? > > nathan >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
