Hi Aleksei,

According to Anna's comment, there are only two things left:

- Adding opt-in for inheritance and turning it off by default.
- Make it possible to query options for the package. There is one nontrivial 
design decision though. Should it be possible to query the options of another 
package (e.g.: should the Malloc checker be able to query the options of the 
osx package)?

Are you going to do these changes? If you need any help feel free to ping me. 
If you do not want to finish this patch I am volunteering to do it.


================
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:114
@@ +113,3 @@
+      return StringRef(i->getValue());
+    size_t pos = Name.rfind('.');
+    if (pos == std::string::npos)
----------------
nit: Local variables should start with upper case letters.

http://reviews.llvm.org/D3967

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to