LGTM if that's formatted how clang-format would do it. Otherwise LGTM with the
formatting nit fixed.
REPOSITORY
rL LLVM
================
Comment at: lib/Driver/ToolChains.cpp:1786-1788
@@ -1785,3 +1785,5 @@
addMultilibFlag(CPUName == "mips32", "march=mips32", Flags);
- addMultilibFlag(CPUName == "mips32r2", "march=mips32r2", Flags);
+ addMultilibFlag(CPUName == "mips32r2" || CPUName == "mips32r3" ||
+ CPUName == "mips32r5",
+ "march=mips32r2", Flags);
addMultilibFlag(CPUName == "mips32r6", "march=mips32r6", Flags);
----------------
Nit: Is this what clang-format would do? I would have expected:
addMultilibFlag(
CPUName == "mips32r2" || CPUName == "mips32r3" || CPUName == "mips32r5",
"march=mips32r2", Flags);
http://reviews.llvm.org/D7879
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
