On 02/26/2015 03:09 AM, Anastasia Stulova wrote:
Hi Matt,
Thanks for your comments.
>I think this needs a test that includes checking the emitted IR.
No problem. I will add that!
>Would it be reasonable to fix this more generally for all builtins? I
know this is a problem for many others that accept pointers
This fix is not specific to c11 compare exchange atomic, but to
atomics with a pointer as second parameter. Do you mean generalization
for other parameters here? Could you tell me what atomic functions
should I be looking at?
Anastasia
I mean generalization for other builtins with pointer operands. For
example, Tom is currently trying to fix __builtin_nanf for OpenCL.
Strings in OpenCL are in the constant address space, but the type
checking of the builtin assumes implicitly assumes the pointer should be
address space 0, so the builtin is incorrectly rejected
-Matt
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
