Hi, So our windows bots seem to break on rev 231312. In looking at the test for mdvc-link.c, I noticed that the check for "link.exe" had both open and close quotes. Since the absolute path to link.exe will most likely always be longer I changed the test to just remove the open quotes. Since I do not have commit privileges, if the attached patch is acceptable would someone please commit it for me?
Thanks, Mike (sqlbyme) Mike Edwards Staff DevOps Engineer Platform Architecture Sony PlayStation® Worldwide Studios 2207 Bridgepointe Pkwy. Mailstop 23163 San Mateo, CA 94404 [email protected]<mailto:[email protected]> P: 650.655.5352 C: 650.483.0328
diff --git a/test/Driver/msvc-link.c b/test/Driver/msvc-link.c index a93ecaf..b44e382 100644 --- a/test/Driver/msvc-link.c +++ b/test/Driver/msvc-link.c @@ -1,11 +1,11 @@ // RUN: %clang -target i686-pc-windows-msvc -### %s 2>&1 | FileCheck --check-prefix=BASIC %s -// BASIC: "link.exe" +// BASIC: link.exe" // BASIC: "-out:a.exe" // BASIC: "-defaultlib:libcmt" // BASIC: "-nologo" // RUN: %clang -target i686-pc-windows-msvc -shared -o a.dll -### %s 2>&1 | FileCheck --check-prefix=DLL %s -// DLL: "link.exe" +// DLL: link.exe" // DLL: "-out:a.dll" // DLL: "-defaultlib:libcmt" // DLL: "-nologo"
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
