On Wed, Mar 11, 2015 at 5:57 PM, David Blaikie <[email protected]> wrote:

>
>
> On Wed, Mar 11, 2015 at 9:47 AM, Alexander Kornienko <[email protected]>
> wrote:
>
>> Author: alexfh
>> Date: Wed Mar 11 11:47:27 2015
>> New Revision: 231938
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=231938&view=rev
>> Log:
>> [clang-tidy] Clean up misc-use-override warning. NFC
>>
>> Modified:
>>     clang-tools-extra/trunk/clang-tidy/ClangTidy.h
>>
>> Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidy.h?rev=231938&r1=231937&r2=231938&view=diff
>>
>> ==============================================================================
>> --- clang-tools-extra/trunk/clang-tidy/ClangTidy.h (original)
>> +++ clang-tools-extra/trunk/clang-tidy/ClangTidy.h Wed Mar 11 11:47:27
>> 2015
>> @@ -113,7 +113,7 @@ public:
>>      assert(!CheckName.empty());
>>    }
>>
>> -  virtual ~ClangTidyCheck() {}
>> +  ~ClangTidyCheck() override = default;
>>
>
> Just remove this, then - since it's the implicit default anyway?
>

I didn't want to rely on the implementation (that the class derives from
another class that has a virtual destructor). Or would I get a warning in
case I removed the inheritance?
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to