Re: [PATCH] Refactor: Simplify boolean expresssions in lib/Lex

[David Blaikie]

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8531

Files:
  cfe/trunk/lib/Lex/LiteralSupport.cpp

Index: cfe/trunk/lib/Lex/LiteralSupport.cpp
===================================================================
--- cfe/trunk/lib/Lex/LiteralSupport.cpp
+++ cfe/trunk/lib/Lex/LiteralSupport.cpp
@@ -144,7 +144,7 @@
       int CharVal = llvm::hexDigitValue(ThisTokBuf[0]);
       if (CharVal == -1) break;
       // About to shift out a digit?
-      Overflow |= (ResultChar & 0xF0000000) ? true : false;
+      Overflow |= ResultChar & 0xF0000000;
       ResultChar <<= 4;
       ResultChar |= CharVal;
     }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/

Index: cfe/trunk/lib/Lex/LiteralSupport.cpp
===================================================================
--- cfe/trunk/lib/Lex/LiteralSupport.cpp
+++ cfe/trunk/lib/Lex/LiteralSupport.cpp
@@ -144,7 +144,7 @@
       int CharVal = llvm::hexDigitValue(ThisTokBuf[0]);
       if (CharVal == -1) break;
       // About to shift out a digit?
-      Overflow |= (ResultChar & 0xF0000000) ? true : false;
+      Overflow |= ResultChar & 0xF0000000;
       ResultChar <<= 4;
       ResultChar |= CharVal;
     }

_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits