Patch LGTM! ~Aaron
On Wed, Mar 18, 2015 at 9:27 PM, Yunzhong Gao <[email protected]> wrote: > Hi, > PS4 target recognizes the #pragma comment() syntax as in -fms-extensions, but > only handles the > case of #pragma comment(lib). This patch adds a warning if any other > arguments are encountered. > > This patch also refactors the code in ParsePragma.cpp a little bit to make it > more obvious that some > codes are being shared between -fms-extensions and PS4 target. > > Could someone kindly take a look at the patch? > - Gao > > http://reviews.llvm.org/D8432 > > Files: > include/clang/Basic/DiagnosticParseKinds.td > lib/Parse/ParsePragma.cpp > test/CodeGen/pragma-comment.c > test/Preprocessor/pragma_ps4.c > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
