The current patch does not address Hubert's test case involving
parenthesis and results in spurious diagnostics for cases like:
_Pragma(void foo() { /* Bad */ })I still think this patch would benefit from using a BalancedDelimiterTracker that's available to the preprocessor. We run into this in other circumstances as well (such as __has_feature and friends), and so it seems like now is a reasonable time to make this improvement. ~Aaron On Fri, Mar 20, 2015 at 10:15 AM, Rachel Craik <[email protected]> wrote: > Ping > > > http://reviews.llvm.org/D8308 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
