One stylistic comment from me; otherwise looks just fine. I'll defer to Richard as he has much more expertise here.
================ Comment at: lib/Sema/SemaChecking.cpp:913 @@ +912,3 @@ + case PPC::BI__builtin_tbegin: + case PPC::BI__builtin_tend: i = 0; l = 0; u = 1; break; + case PPC::BI__builtin_tsr: i = 0; l = 0; u = 7; break; ---------------- I don't particularly like this style of putting the code on the same line as the case (I realize it fits in with the surrounding code). It obfuscates that this code is shared by tbegin and tend, for example. http://reviews.llvm.org/D8672 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
