John, thanks for the review!
================ Comment at: lib/CodeGen/CGStmtOpenMP.cpp:1109 @@ +1108,3 @@ + auto &C = CGF.CGM.getContext(); + llvm::AtomicRMWInst::BinOp Op = llvm::AtomicRMWInst::BAD_BINOP; + // Emit atomicrmw only if 'x' and 'expr' are integer values, lvalue for 'x' ---------------- rjmccall wrote: > I would split this out as a helper function that returns an > Optional<llvm::AtomicRMWInst::BinOp>. Agree, moved to static getCompatibleAtomicRMWBinOp(). http://reviews.llvm.org/D8536 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
