================ Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:226 @@ +225,3 @@ + /// region specified in \a CurrentCodeGenKinds list. + void nextCodeGenKind(ArrayRef<OpenMPDirectiveKind> CurrentCodeGenKinds); + /// \brief Make current combined region to emit code for \a At OpenMP region ---------------- rjmccall wrote: > This is a weird API; its state is half internal (the current index) and half > external (the actual array). It should really own both parts or neither. > For example, I have no idea what the combined region info can actually do > with "CurrentKindPos" without knowing the array. John, I agree. I also thought about it. I think I'd remove CurrentKindPos and will use nextCodeGenKindAtSpecified() everywhere.
http://reviews.llvm.org/D8631 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
