================ Comment at: lib/Driver/ToolChains.cpp:2447 @@ +2446,3 @@ + TheTriple.getEnvironment() == llvm::Triple::UnknownEnvironment) + TheTriple.setEnvironment(llvm::Triple::GNUEABIHF); + return TheTriple.getTriple(); ---------------- jvoung wrote: > dschuff wrote: > > jvoung wrote: > > > Is there anywhere that would warn if plain "gnueabi" was specified? > > This just covers the case if it's not specified. If gnueabi is specified > > that should override this default and be honored. Since the behavior of the > > regular arm compiler is just to allow the user to do that, maybe we should > > too? > If gnueabi is allowed, then perhaps the "StringRef > tools::arm::getARMFloatABI()" code should check for it, rather than force > hard-float. OK, done. this means we can just fall into the default case and be more like Linux, both there and clang::AddARMTargetArgs() which is probably a good thing. I did those changes before adding this code to set the default in a later CL... it ended up being necessary for other reasons (https://codereview.chromium.org/838933004). This seemed like a bit more dubious change at the time but it's nice in that it's localized to NaCl_TC and that it allows fewer exceptional cases elsewhere.
I think this is fine and can land for now, but more generally, do agree that it's nice to allow environments other than gnueabihf and/or to do so without warning? http://reviews.llvm.org/D8590 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
