Yeah, this isn't what we want. Go ahead and revert. On Thu, Mar 26, 2015 at 9:37 AM, Eric Fiselier <[email protected]> wrote:
> ping. > > On Wed, Mar 18, 2015 at 10:19 PM, Eric Fiselier <[email protected]> wrote: > > Can you explain why you need this? > > > > Previously these header files get installed under the c++ standard > > library include directory (typically <root>/include/c++/v1) which is > > not a default directory. > > Now they get installed along what is likely a default system header > > search path. This is probably not what we want. > > > > For example, I ran into trouble trying to compile a program that uses > > GNU's libunwind with g++ and libstdc++. The build would pick up > > libc++abi's "unwind.h" which was installed in "/usr/local/include" and > > then it would link to GNU's libunwind which resulted in a bunch of > > undefined symbols. > > > > I think we should revert this and go back to the old behavior of not > > installing these headers until we can come up with a better way to do > > this. > > > > /Eric > > > > > > > > On Thu, Feb 5, 2015 at 5:46 PM, Greg Fitzgerald <[email protected]> > wrote: > >> Author: garious > >> Date: Thu Feb 5 16:46:43 2015 > >> New Revision: 228351 > >> > >> URL: http://llvm.org/viewvc/llvm-project?rev=228351&view=rev > >> Log: > >> Install header files > >> > >> Modified: > >> libcxxabi/trunk/CMakeLists.txt > >> > >> Modified: libcxxabi/trunk/CMakeLists.txt > >> URL: > http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/CMakeLists.txt?rev=228351&r1=228350&r2=228351&view=diff > >> > ============================================================================== > >> --- libcxxabi/trunk/CMakeLists.txt (original) > >> +++ libcxxabi/trunk/CMakeLists.txt Thu Feb 5 16:46:43 2015 > >> @@ -315,3 +315,10 @@ if(NOT LIBCXXABI_ENABLE_SHARED) > >> else() > >> add_subdirectory(test) > >> endif() > >> + > >> +install(DIRECTORY include/ > >> + DESTINATION include > >> + FILES_MATCHING > >> + PATTERN "*.h" > >> + PATTERN ".svn" EXCLUDE > >> +) > >> > >> > >> _______________________________________________ > >> cfe-commits mailing list > >> [email protected] > >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
