On 05.04.2015 7:16, Anna Zaks wrote:
Hi Anton,
Have you tested the patch on anything but the regression tests? If
yes, what are the results? Did this catch any issues? Are there any
false positives? Since this will be a turned on by default new
warning, I'd like make sure we test on real code before committing.
Ran the checker over LLVM and Ogre codebases, neither false-positives
nor issues found except for one artificially injected issue. Ok to commit?
Other than testing, this looks good to me. Thank you!
Anna.
On Sat, Mar 21, 2015 at 7:19 AM, Антон Ярцев <[email protected]
<mailto:[email protected]>> wrote:
.
================
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:889
@@ +888,3 @@
+ const RefState *RS = State->get<RegionState>(Sym);
+ if (!RS || !RS->isAllocated())
+ return State;
----------------
ayartsev wrote:
> zaks.anna wrote:
> > It should not be possible to have non allocated symbol here..
Is it? Maybe we should assert?
> Agree, done!
Pardon, currently zero-allocated realloc do not attach a RefState
so it is still early to assert for now.
Is there a test for this? If not, please add one.
Added several realloc() tests with TODO comments.
http://reviews.llvm.org/D8273
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
--
Anton
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
