- switch (CandidateSet.BestViableFunction(S, From->getLocStart(),
Best, true)) {
+ OverloadingResult OVLReasult =
+ CandidateSet.BestViableFunction(S, From->getLocStart(), Best, true);
+ switch (OVLReasult) {
Please move the variable declaration into the switch:
switch (auto Result = CandidateSet.BestViableFunction(...))
Otherwise, LGTM, thanks!
On Mon, Apr 13, 2015 at 3:54 PM, jahanian <[email protected]> wrote:
> This patch fixes a crash in release build clang and produces the desired
> diagnostic.
> In the debug build clang it does not crash but produces a misleading
> diagnostic.
>
> Problem is that in TryUserDefinedConversion(…)
> We have:
> case OR_Deleted:
> // ….
> if (CXXConstructorDecl *Constructor
> =
> dyn_cast<CXXConstructorDecl>(ICS.UserDefined.ConversionFunction)) {
> // …
> }
>
> And ICS.UserDefined.ConversionFunction never gets set for a ‘delete’
> constructor.
>
> Please review.
>
> - Fariborz
>
>
>
>
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
