On 17/04/2015 15:33, Aaron Ballman wrote: > On Fri, Apr 17, 2015 at 9:21 AM, Sylvestre Ledru <[email protected]> wrote: >> Author: sylvestre >> Date: Fri Apr 17 08:21:39 2015 >> New Revision: 235190 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=235190&view=rev >> Log: >> Remove the assertion as it was useless and broken. >> >> Enforcing the assert caused the following tests to fail: >> Clang :: Analysis__bstring.c >> Clang :: Analysis__comparison-implicit-casts.cpp >> Clang :: Analysis__malloc-interprocedural.c >> Clang :: Analysis__malloc.c >> Clang :: Analysis__redefined_system.c >> Clang :: Analysis__string.c >> Clang :: Analysis__weak-functions.c > > While the assert may have been broken, I am concerned that the > author's assumptions are being violated in some way. Can the original > code author weigh in on whether that assert is truly useless or not? > That appears to be Jordan in this case, according to a quick svn > blame. Yes, sorry about that. I fixed it quickly and maybe not using the best way. However, the incorrect assertion (fixed r235188) has been there for a few years.
Sylvestre _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
