Done. I posted the unit test and fix as separate reviews. - http://reviews.llvm.org/D9126 (proposed unit test) - http://reviews.llvm.org/D9127 (proposed fix)
Tom. On 04/19/2015 11:54 PM, Manuel Klimek wrote:
Tom, would you mind putting the review on http://reviews.llvm.org/ (that way I'll get to it faster). You can follow the steps here: http://llvm.org/docs/Phabricator.html. Don't forget to cc cfe-commits on the patch as subscriber. On Sat, Apr 18, 2015 at 4:45 AM Tom Honermann <[email protected] <mailto:[email protected]>> wrote: Thanks all for following up on this. I had added comments to the BZ detailing the issue and the patches attached. If those comments are insufficient to explain the issue, how I addressed it, or details of the unit test, I'll be happy to add more detail. https://llvm.org/bugs/show_bug.cgi?id=23175 Tom. On 04/17/2015 09:42 PM, Nikola Smiljanic wrote: > Two patches are attached in the bug report, fix and unittest. The code > is tooling related so you seem like a good choice :) I had a look but am > clueless when it comes to this part of clang. > > On Sat, Apr 18, 2015 at 11:40 AM, Manuel Klimek <[email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > What do I need to do here? > > On Fri, Apr 17, 2015 at 6:34 PM Nikola Smiljanic <[email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > Adding Klimek to help move this along :) > > On Wed, Apr 15, 2015 at 5:34 AM, Tom Honermann > <[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>> wrote: > > Removing cfe-dev; CCing cfe-commits and akirtzidis (who svn > suggests has previously made changes in this area. I'm > guessing at an email address for akirtzidis). > > Tom. > > On 04/14/2015 03:52 AM, Nikola Smiljanic wrote: > > Please send patches to cfe-commits or use Phabricator, > they'll just get > lost in the issue tracker. Make sure you CC someone as well. > > On Tue, Apr 14, 2015 at 12:02 AM, Tom Honermann > <[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>> > <mailto:[email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>>>> wrote: > > Could someone be so kind as to review the patches > attached to > PR23175 and, assuming no concerns, commit them? > > Bug 23175 - Infinite loop iterating Objective-C > method declarations > in categories when the AST was deserialized from an > .ast file > https://llvm.org/bugs/show___bug.cgi?id=23175 > <https://llvm.org/bugs/show_bug.cgi?id=23175> > > Thank you, > Tom. > _________________________________________________ > cfe-dev mailing list > [email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>> > <mailto:[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>> > http://lists.cs.uiuc.edu/__mailman/listinfo/cfe-dev > <http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev> > > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
