OK, the combination of these two changes LGTM (modulo renaming the test file and removing the PR number). For future reference, it's our convention to include the code change and tests in the same review.
Do you need someone to commit this for you? REPOSITORY rL LLVM ================ Comment at: lib/Serialization/ASTReaderDecl.cpp:984-985 @@ -983,3 +983,4 @@ VisitObjCContainerDecl(D); - D->setClassInterface(ReadDeclAs<ObjCInterfaceDecl>(Record, Idx)); + // For ObjCCategoryImplDecl, setClassInterface must not be called until the + // category identifier has been deserialized and set. See PR23175. } ---------------- tahonermann wrote: > rsmith wrote: > > Don't add PR references to the code; your comments should be complete > > enough to explain why we're doing what we're doing now without reference to > > what we got wrong before. In this case, I think they are. (People > > interested in the code's history can check the SVN logs.) > Funny. Usually I'm the one telling people not to add such references. Would > you like me to repost the patch with the PR reference removed? Nah, whoever commits can just do that before checkin. http://reviews.llvm.org/D9127 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
