On Wed, May 6, 2015 at 8:44 AM, Eli Bendersky <[email protected]> wrote:
> LGTM > > [assuming this just copies stuff from http://reviews.llvm.org/D8463 w/o > modifications] > > The only change is that generated code uses '__' prefix for symbols it creates instead of '.' used in D8463 <http://reviews.llvm.org/D8463>. No functional changes otherwise. > > ================ > Comment at: lib/CodeGen/CGCUDANV.cpp:43 > @@ +42,3 @@ > + llvm::SmallVector<llvm::Function *, 16> EmittedKernels; > + /// Keeps track of variables containing handles of GPU binaries > Populated by > + /// ModuleCtorFunction() and used to create corresponding cleanup calls > in > ---------------- > Nit: period (or semicolon) after "binaries"? > Dot was missing. Fixed. --Artem
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
