A couple of high-level comments: I don't really like making this a sanitizer. It is supposed to be useable in the same places stack canaries are used (i.e. in production, with a view to enabling it for 100% of code). Making it an -fsanitize option makes it seem like a debugging tool, not a mitigation tool.
I'm also not 100% convinced by the compiler-rt stuff. This needs to be in libc. What happens when a program dlopens libpthread? The pthread_create symbol won't exist on library load, so it looks as if your interceptor code will just see a null pointer. Then when the first thread is created, it will die horribly. http://reviews.llvm.org/D6096 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
