Looks good.
================
Comment at: lib/Format/UnwrappedLineFormatter.cpp:479
@@ -478,1 +478,3 @@
}
+ if (TheLine.Type == LT_Invalid && ShouldFormat && IncompleteFormat) {
+ *IncompleteFormat = true;
----------------
No braces.
================
Comment at: unittests/Format/FormatTest.cpp:25-27
@@ +24,5 @@
+ enum IncompleteCheck {
+ IFA_ExpectComplete,
+ IFA_ExpectIncomplete,
+ IFA_DoNotCheck
+ };
----------------
IFA?
================
Comment at: unittests/Format/FormatTest.cpp:40
@@ +39,3 @@
+ if (CheckIncomplete != IFA_DoNotCheck)
+ EXPECT_EQ(CheckIncomplete == IFA_ExpectIncomplete, IncompleteFormat)
+ << Code << "\n\n";
----------------
I suspect that this looks a bit complicated in the test output when it actually
triggers. Might be better to pull out the comparison into a local variable.
http://reviews.llvm.org/D9532
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
