Hi Renato, Thanks. OK, this looks good to me.
Cheers, James On Fri, 8 May 2015 at 13:20 Renato Golin <[email protected]> wrote: > Hi James, > > All of this will need some change when the target parser is in use, but > that shouldn't stop you from adding this ARMv8 support in the driver. Feel > free to commit this change, and I'll rebase when I do mine. > > It would be helpful to add a "FIXME: Use ARMTargetParser" on everything > that needs a proper lookup table, so that I can grep later and replace. But > since those rules are delicate, and most of them use string comparisons, > replacing them for proper lookup tables will take a lot of care and time, > so it'll happen one at a time, in the near future. > > Feel free to approve this one as you see fit, and we'll work around later. > > cheers, > --renato > > > REPOSITORY > rL LLVM > > http://reviews.llvm.org/D8799 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
