> On 2015 May 7, at 17:42, Diego Novillo <[email protected]> wrote: > > On Thu, May 7, 2015 at 2:42 PM, Diego Novillo <[email protected]> wrote: >> On Fri, May 1, 2015 at 3:22 PM, Geoff Berry <[email protected]> wrote: >> >>> Index: lib/CodeGen/CodeGenAction.cpp >>> =================================================================== >>> --- lib/CodeGen/CodeGenAction.cpp >>> +++ lib/CodeGen/CodeGenAction.cpp >>> @@ -434,7 +434,13 @@ >>> FileManager &FileMgr = SourceMgr.getFileManager(); >>> StringRef Filename; >>> unsigned Line, Column; >>> - D.getLocation(&Filename, &Line, &Column); >>> + if (D.isLocationAvailable()) >>> + D.getLocation(&Filename, &Line, &Column); >>> + else { >>> + Filename = "<unknown>"; >>> + Line = 0; >>> + Column = 0; >>> + } >> >> Odd, this code used to unavailable locations > > "used to deal with unavailable..."
I probably broke this at some point when I was transitioning to the new debug info hierarchy. The old hierarchy's accessors checked for NULL and give default answers, whereas the new hierarchy just uses pointers directly. At some point I switched the accessors to start asserting and fixed any bugs that uncovered, but I guess there wasn't any test coverage here so I missed it. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
