Yeah that was actually going to be my followup question, how many other places need this. My concern about just grepping and changing was just the issue I encountered here, where the linkage type was actually not finally set at the point where the comdat was added (hence moving it from generateThunk to emitThunk).
Also it looks like many of those cases can actually use the existing maybeAddTrivialComdat because they have Decls available. Anyway here's another patch with a maybeSetTrivialComdat overload. Do you have an opinion about whether it should take a GlobalValue or just a GlobalObject? I'm a little bit unclear about linkage and comdats for aliases. http://reviews.llvm.org/D9580 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
