================
Comment at: lib/CodeGen/ABIInfo.h:93
@@ -92,1 +92,3 @@
+ virtual bool shouldSignExtUnsignedType(QualType Ty) const {
+ return false;
----------------
Nit: Just for consistency let's:
- define this routine in the cpp file
- move the declaration closer to other virtual functions declared in this
class
================
Comment at: lib/CodeGen/TargetInfo.cpp:5800
@@ +5799,3 @@
+ return true;
+ else
+ return false;
----------------
Nit: **else-after-return** violation.
```
return Ty->isUnsignedIntegerOrEnumerationType() && TySize == 32;
```
or
```
if (Ty->isUnsignedIntegerOrEnumerationType() && TySize == 32)
return true;
return false;
```
And +1 for comment
http://reviews.llvm.org/D9198
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
