My first post to this email group, but as a newcomer to the code base, I personally find *not* chaining the return statements more readable and easier to follow.
On Tue, May 26, 2015 at 6:10 PM, David Blaikie <[email protected]> wrote: > > > On Tue, May 26, 2015 at 4:06 PM, Richard <[email protected]> wrote: > >> In http://reviews.llvm.org/D10019#178722 >> <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10019-23178722&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=vnqjrIrq4zRNMc7ROV2-KOWCElESXX4K-FEDZGaotlo&s=LVpYqL5rXNQFpxXPU_iRyMYQMUDkdqvxmgvWjphJjas&e=>, >> @dblaikie wrote: >> >> > We should come to some conclusion about these chained return cases - >> they seem fairly benign/not buggy/not worth changing. >> >> >> Ah... I see what you mean. So like the other case where it was something >> like `if (expr) var = true; else if (expr2) var = true; else if (expr3) var >> = true; else var = false;`, you'd like the option of disabling this check >> when it is a series of chained return statements? >> > > Yeah, they seem equivalent > > >> That's great feedback and is something I can do to enhance the check. >> >> >> http://reviews.llvm.org/D10019 >> <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10019&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=vnqjrIrq4zRNMc7ROV2-KOWCElESXX4K-FEDZGaotlo&s=uQp5L4RIBR5AZdHoumQTnUcN87v-xP1LyA8YVQ5T-Ng&e=> >> >> EMAIL PREFERENCES >> http://reviews.llvm.org/settings/panel/emailpreferences/ >> <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=vnqjrIrq4zRNMc7ROV2-KOWCElESXX4K-FEDZGaotlo&s=b2n6oJIk2UGuMfLZ2aY6ivPrYnDFWR73hSuDPksZx44&e=> >> >> >> > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
