+ StringRef MCPU = StringRef(A->getValue()).lower(); lower returns an std::string which will be immediately deleted leaving the MCPU StringRef pointing at stale memory. MCPU should be a std::string.
On Mon, Jun 1, 2015 at 10:02 AM, Richard Barton <[email protected]> wrote: > My only observation is that you have changed the Krait codepath, but have > not added a test for that. > > Otherwise LGTM. > > > REPOSITORY > rL LLVM > > http://reviews.llvm.org/D10162 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > -- ~Craig
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
