Hi Luke,
Thanks for the change, looks good to me, now. Feel free to commit with the
nitpick changes.
cheers,
--renato
================
Comment at: lib/CodeGen/CGBuiltin.cpp:3310
@@ +3309,3 @@
+
+ if (RegisterType->isIntegerTy(64) && ValueType->isIntegerTy(32))
+ // Read into 64 bit register and then truncate result to 32 bit.
----------------
nitpick: this could be commoned up with the write version below:
bool MixedTypes = RegisterType->isIntegerTy(64) &&
ValueType->isIntegerTy(32);
Maybe we should assert that the other way around doesn't happen:
assert(!(RegisterType->isIntegerTy(32) && ValueType->isIntegerTy(64)) &&
"Can't fit 64-bit value in 32-bit register");
http://reviews.llvm.org/D9697
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
