LGTM with comment.

================
Comment at: test/Driver/cl-outputs.c:266
@@ -265,3 +265,3 @@
 // Fio4: "-E"
-// Fio4: "-o" "foo.x"
+// Fio4: "-o" "cl-outputs.i"
 
----------------
We probably don't need all four test cases for /P with /o anymore.

I think we should also have a note explaining the expected behaviour: that /o 
doesn't affect /P.

http://reviews.llvm.org/D10313

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to