On 6/8/15 3:29 PM, Nick Sumner wrote:
Thanks. Can you please commit it?
Sure. Committed r239406. Build breakage (on non x86 hosts) fixed in r239407.
If you are (or anyone else is) interested, I've got two other
outstanding patches for AST printing bugs:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150525/130001.html
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150525/130082.html'
I'll take a look.
Jon
Thanks,
Nick
On Mon, Jun 8, 2015 at 12:11 PM, Jonathan Roelofs
<[email protected]> wrote:
On 6/8/15 12:55 PM, Nick Sumner wrote:
Hi all,
The attached patch fixes a bug with printing GCCAsmExprs. Presently,
the required parentheses around input and output arguments are
omitted. Thus, given the code:
__asm__ __volatile__("addl %%ebx,%%eax" : "=a" (added) : "a" (1), "b" (2)
);
The expr is presently printed as:
asm volatile ("addl %%ebx,%%eax" : "=a" added : "a" 1, "b" 2);
With the patch, the expr is printed as:
asm volatile ("addl %%ebx,%%eax" : "=a" (added) : "a" (1), "b" (2));
LGTM.
Jon
Best,
Nick
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
--
Jon Roelofs
[email protected]
CodeSourcery / Mentor Embedded
--
Jon Roelofs
[email protected]
CodeSourcery / Mentor Embedded
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
