Done in r239816. On Tue, Jun 16, 2015 at 3:04 PM, Tobias Grosser <[email protected]> wrote:
> On 06/16/2015 12:22 PM, Daniel Jasper wrote: > >> Author: djasper >> Date: Tue Jun 16 05:22:10 2015 >> New Revision: 239809 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=239809&view=rev >> Log: >> Tooling: When applying a set of replacements, do deletions before >> insertions. It is unlikely to be the intention to delete parts of newly >> inserted code. To do so, changed sorting Replacements at the same offset >> to have decreasing length. >> > > This seems to have broken some testers which are running with gcc 4.7.2: > > /home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.src/tools/clang/unittests/Tooling/RewriterTest.cpp: > In member function ‘virtual void > clang::tooling::{anonymous}::Rewriter_AdjacentInsertAndDelete_Test::TestBody()’: > /home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.src/tools/clang/unittests/Tooling/RewriterTest.cpp:42:12: > error: ‘clang::tooling::Replacements’ has no member named ‘emplace’ > /home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.src/tools/clang/unittests/Tooling/RewriterTest.cpp:43:12: > error: ‘clang::tooling::Replacements’ has no member named ‘emplace’ > /bin/rm: cannot remove > `/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.obj/tools/clang/unittests/Tooling/Release+Asserts/RewriterTest.d.tmp': > No such file or directory > make[4]: *** > [/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.obj/tools/clang/unittests/Tooling/Release+Asserts/RewriterTest.o] > Error 1 > make[4]: Leaving directory > `/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.obj/tools/clang/unittests/Tooling' > > LLVM is documented to work with gcc 4.7.0 [1], so we may consider fixing > this (the fix is simple). > > Best, > Tobias > > [1] http://llvm.org/docs/GettingStarted.html#software > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
