@jroelofs: Any input on how to better manage the host vs target distinction?


================
Comment at: test/lit.site.cfg.in:10
@@ -9,3 +9,3 @@
 config.enable_shared            = "@LIBCXX_ENABLE_SHARED@"
-config.enable_32bit             = "@LIBCXX_BUILD_32_BITS@"
+config.enable_32bit             = "@LLVM_BUILD_32_BITS@"
 config.enable_global_filesystem_namespace = 
"@LIBCXX_ENABLE_GLOBAL_FILESYSTEM_NAMESPACE@"
----------------
jroelofs wrote:
> `LLVM_BUILD_32_BITS` is a property of the host
> `config.enable_32bit` is a property of the target
> 
> we should keep these separate, and not conflate host & target.... they're not 
> always the same!
I agree but I'm not sure the best way to handle this. compiler-rt and libcxxabi 
both already use LLVM_ENABLE_32BITS and they are libraries intended for the 
target. Do you have a suggestion about how to handle this?

http://reviews.llvm.org/D10055

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to