In http://reviews.llvm.org/D10747#195045, @dblaikie wrote:
> Looks good - alternatively you could phrase this as a single function with > a macro for the nodebug attribute - two clang+FileCheck lines, one passes > -D to enable the nodebug, one passes an empty -D. Might be a more direct > comparison? (& does require two clang invocations, which is a tradeoff) Yeah, but for this it doesn't really seem worthwhile; the functions are pretty trivial and the checks are very generic. For something more specific/fine-tuned, or bigger test functions, it might be more worth it. r240747, thanks! REPOSITORY rL LLVM http://reviews.llvm.org/D10747 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
