REPOSITORY rL LLVM ================ Comment at: lib/Basic/Targets.cpp:4338 @@ +4337,3 @@ + ArchProfile = llvm::ARMTargetParser::parseArchProfile(ArchName); + ArchVersion = llvm::ARMTargetParser::parseArchVersion(ArchName); + ---------------- labrinea wrote: > rengolin wrote: > > You should also set IsThumb and ShouldUseInlineAtomic > Setting IsThumb in setCPU causes regressions. It doesn't make sense to me but > setCPU changes the ISA from thumb to arm. Right, this is a major bug and needs to be addressed. You shouldn't mix TargetParser changes with bug fixes, but would be good to add a FIXME comment and open a bug in bugzilla to describe the problem.
What about ShouldUseInlineAtomic? http://reviews.llvm.org/D10839 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
