Hi Eugene, This patch fails the unittests which also need to be updated to reflect the changes, see
http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/28343 http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/3820 Yaron 2015-07-02 23:24 GMT+03:00 Eugene Kosov <clap...@yandex.ru>: > Commit them, please. I have no commit rights. > > Thanks for the help. > > 02.07.2015, 22:44, "Yaron Keren" <yaron.ke...@gmail.com>: > > Hi Eugene, > > > > These patches LGTM. Should I commit them for you? > > > > Yaron > > > > 2015-06-26 23:33 GMT+03:00 Eugene Kosov <clap...@yandex.ru>: > >> Hi. > >> > >> Thanks for your feedback. I fixed the regression. Here is the new patch. > >> > >> 26.06.2015, 00:51, "Yaron Keren" <yaron.ke...@gmail.com>: > >> > >>> Hi Eugene, > >>> > >>> This patch does not pass clang extra tools regression tests locally, > >>> > >>> FAIL: Clang Tools :: modularize/NoProblems.modularize (7141 of 19860) > >>> Testing: 0 .. 10.. 20.. 30 > >>> FAIL: Clang Tools :: modularize/NoProblemsDependencies.modularize > (7144 of 19860) > >>> Testing: 0 .. 10.. 20.. 30 > >>> FAIL: Clang Tools :: modularize/NoProblemsCoverage.modularize (7145 of > 19860) > >>> (...) > >>> > >>> Please check it out. > >>> > >>> Yaron > >>> > >>> 2015-06-22 15:25 GMT+03:00 Eugene Kosov <clap...@yandex.ru>: > >>>> Hi. > >>>> > >>>> Here are two patches for clang-tools-extra and for clang which > simplifies code a little bit and also removes possibility of implicit > std::string construction. > >>>> > >>>> -- > >>>> Eugene > >>>> > >>>> _______________________________________________ > >>>> cfe-commits mailing list > >>>> cfe-commits@cs.uiuc.edu > >>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >> > >> -- > >> Eugene > > -- > Eugene >
_______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
