danalbert accepted this revision.
danalbert added a comment.
This revision is now accepted and ready to land.

Actually, I don't think there's an issue here from the libc++ side of things; 
we already don't install any of the libunwind headers (though libcxxrt does, so 
maybe we should?).

My concern was: 
https://github.com/llvm-mirror/libcxx/blob/master/cmake/Modules/HandleLibCXXABI.cmake#L92

We install libc++abi headers there, and for libcxxrt we also install the unwind 
headers there. Since this isn't already broken, presumably libunwind is already 
properly separated to not need them there.

Still, as Renato says, we should be installing the libunwind headers 
//somewhere//. Since we don't do any of that yet though, I think it's 
reasonable to save that for a different patch.


http://reviews.llvm.org/D11230




_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to