mclow.lists added a comment.
This looks like a nice simplification, and the test is great.
However, I have some concerns about where the pieces live - see inline comments.
================
Comment at: include/__functional_03:207
@@ -206,3 +206,1 @@
-template<class _Fp> class _LIBCPP_TYPE_VIS_ONLY function; // undefined
-
namespace __function
----------------
It's not clear to me that removing this declaration is correct. There are
specializations of `function` in this file.
================
Comment at: include/__functional_03:761
@@ -771,3 +760,3 @@
{
- if (__not_null(__f))
+ if (__function::__not_null(__f))
{
----------------
Where is `__functional_03` getting the definition of `__not_null` from?
It doesn't include any other headers.
http://reviews.llvm.org/D11111
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
